[PATCH] Fix bug #11565 - Memory leak of struct gensec_security_ops *.

Jeremy Allison jra at samba.org
Wed Oct 21 20:02:43 UTC 2015


Pretty obvious transposed parameters in a list
when calling gensec_spnego_server_try_fallback().

Please review and push !

Thanks,

Jeremy.
-------------- next part --------------
From 4d91f5587f0648382a5f6d600254d5d2637babe6 Mon Sep 17 00:00:00 2001
From: Jeremy Allison <jra at samba.org>
Date: Wed, 21 Oct 2015 11:13:46 -0700
Subject: [PATCH] auth: gensec: Parameters out_mem_ctx and ev are passed in the
 wrong order to gensec_spnego_server_try_fallback().

Fix suggested by <lev at zadarastorage.com>. Fixes a memory leak.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=11565

Signed-off-by: Jeremy Allison <jra at samba.org>
---
 auth/gensec/spnego.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/auth/gensec/spnego.c b/auth/gensec/spnego.c
index c111b85..73c76eb 100644
--- a/auth/gensec/spnego.c
+++ b/auth/gensec/spnego.c
@@ -738,7 +738,7 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
 			len = spnego_read_data(gensec_security, in, &spnego);
 			if (len == -1) {
 				return gensec_spnego_server_try_fallback(gensec_security, spnego_state,
-									 out_mem_ctx, ev, in, out);
+									 ev, out_mem_ctx, in, out);
 			}
 			/* client sent NegTargetInit, we send NegTokenTarg */
 
-- 
2.6.0.rc2.230.g3dd15c0



More information about the samba-technical mailing list