[PR PATCH] [Updated] repl_meta_data fixes

Stefan Metzmacher metze at samba.org
Wed Oct 21 14:40:57 UTC 2015


Am 21.10.2015 um 00:50 schrieb github at samba.org:
> There is an updated pull request by abartlet against master on the Samba Samba Github repository
> 
> https://github.com/abartlet/samba repl_meta_data-fixes
> https://github.com/samba-team/samba/pull/26
> 
> repl_meta_data fixes
> While developing the demote-dc branch adding better support for 'samba-tool domain demote --remove-other-dead-server' command I tested against a clone of a Windows 2012R2 server.  Removing an RODC triggered a failure due to the binary linked attribute msDS-RevealedUsers

Regarding the first patch, what's the interaction of
ldb_asprintf_errstring() and ldb_module_oom(module)?
This is quite confusing that we have ldb_module_oom(module) in some places
and remove it in others.

Regarding the 2nd patch, is this the fix for
https://bugzilla.samba.org/show_bug.cgi?id=11139 ?
If so please add the bug url to the commit message

Why "if (sa->linkID != 0 && (sa->linkID & 1)) {"
can't this be simply "if (sa->linkID & 1) {" ?

BTW: can we have the attachements as "Content-Type: text/plain;
charset=UTF-8;"
instead of "application/text/x-diff".

Having an idication of fullname of the submitter in the From: header and/or
a Reply-To: header would also be nice.

Having the mails gpg signed would be also great, but maybe a task for
another day.

metze

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151021/b6fa23dc/signature.sig>


More information about the samba-technical mailing list