[PATCH] Fix bug 11452 - DOS Client Cannot Delete *.*

[Andreas Schneider]

On Tuesday 20 October 2015 12:39:13 Jeremy Allison wrote:
> On Tue, Oct 20, 2015 at 04:00:55PM +0200, Andreas Schneider wrote:
> > On Monday 19 October 2015 16:24:18 Jeremy Allison wrote:
> > > In the wildcard pathname delete code path
> > > we forgot to map 0 -> FILE_ATTRIBUTE_NORMAL
> > > as we do in the non-wildcard delete path.
> > > 
> > > This breaks an old DOS client that depends
> > > on this behavior. Includes regression test
> > > I tested against Win2k12r2.
> > > 
> > > Review and push welcome !
> > > 
> > > Thanks,
> > > 
> > > Jeremy.
> > 
> > RB+ and pushed to autobuild
> 
> Ah - fails on source4/torture/raw/unlink.c,
> but that test code is incorrect anyway (it adds
> a special return check for NT_STATUS_NO_SUCH_FILE
> if the server is Samba3 - Samba should return
> NT_STATUS_OK here as Windows does).
> 
> That's kind of funny - as it means we already
> had a proper test for this but instead of
> noticing and fixing the bug in the server,
> we hacked in a "if Samba3" workaround for
> our incorrect response :-) :-).
> 
> Updated patch attached. Andreas if you
> could just review the samba3.raw.unlink
> fixup (last hunk of the patch) it's
> good to go !
> 
> Cheers (and sorry about the error),
> 
> Jeremy.

Pushed to autobuild

-- 
Andreas Schneider                   GPG-ID: CC014E3D
Samba Team                             asn at samba.org
www.samba.org