[PATCH] dynconfig: Fix deps, no talloc required
Andreas Schneider
asn at samba.org
Wed Oct 21 06:25:21 UTC 2015
On Wednesday 21 October 2015 14:54:53 Andrew Bartlett wrote:
> On Wed, 2015-10-21 at 14:49 +1300, Andrew Bartlett wrote:
> > On Mon, 2015-10-12 at 12:18 +0200, Volker Lendecke wrote:
> > > Hi!
> > >
> > > Review&push appreciated!
> >
> > Volker,
> >
> > On a host that does not have talloc.h from the system (such as our
> > catalyst cloud hosts, or the travis-ci hosts I'm trying to make
> > work),
> > sadly this breaks the build:
> >
> > In file included from ../dynconfig/dynconfig.c:21:0:
> > ../source4/include/includes.h:54:20: fatal error: talloc.h: No such
> > file or directory
> > #include <talloc.h>
> > ^
> > compilation terminated.
> > Waf: Leaving directory `/home/ubuntu/autobuild/b13318/samba-libs/bin'
> >
> > This additional patch fixes that issue, by depending on replace.h
> > instead of includes.h (which is thankfully already a dependency in
> > waf).
> >
> > Please review/push!
>
> (and if I had used the magic word 'attached', then my mailer would have
> avoided this small embarrassment). Now attached.
>
> Thanks,
>
> Andrew Bartlett
RB+ and pushed to autobuild
--
Andreas Schneider GPG-ID: CC014E3D
Samba Team asn at samba.org
www.samba.org
More information about the samba-technical
mailing list