Having problems understanding async_connect_send and async_connect_connected in lib/async_req/async_soc.c

[Andrew Bartlett]

On Tue, 2015-10-20 at 10:49 -0700, Jeremy Allison wrote:
> On Tue, Oct 20, 2015 at 05:44:30PM +0200, Ralph Boehme wrote:
> > 
> > couldn't resist, played some more with this. Turns out Solaris
> > *will*
> > return EISCONN when connect() is called a second time, so imo we
> > have
> > a bug:
> > 
> > <https://bugzilla.samba.org/show_bug.cgi?id=11564>
> > 
> > Patch attached. I've also crafted a test, which at least ensures
> > basic
> > functionality of async_connect_send() while not really able to
> > detect
> > this corner case. Not sure if we want the test in master.
> 
> Yeah, I think we do !
> 
> However the test has a problem (in theory if not in practice :-).
> 
> port must be uint16_t, and should go up to UINT16_MAX,
> not INT32_MAX.
> 
> > Please review carefully and push if ok. Thanks!
> 
> Modified version attached. Push if you're happy !

I need this commit for this to compile for me on gcc version 5.2.1 

(Yay for picky compilers!)

Please review and I'll push with the README change.

Thanks,

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba





-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-selftest-Fix-memset-parameters-in-test-for-async_con.patch
Type: text/x-patch
Size: 1275 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151021/8cbb957c/0001-selftest-Fix-memset-parameters-in-test-for-async_con.bin>