[PR PATCH] Simple samba fixes

Andrew Bartlett abartlet at samba.org
Tue Oct 20 21:31:54 UTC 2015


On Tue, 2015-10-20 at 11:21 -0700, Jeremy Allison wrote:
> On Mon, Oct 19, 2015 at 11:31:34PM +0000, github at samba.org wrote:
> > There is a new pull request by abartlet against master on the Samba
> > Samba Github repository
> > 
> > https://github.com/abartlet/samba simple-samba-fixes
> > https://github.com/samba-team/samba/pull/20
> > 
> > Simple samba fixes
> > A small set of fixes to Samba that should be 'obviously correct'
> > enough for an easy review.
> > 
> > A patch file from https://github.com/samba-team/samba/pull/20.patch
> >  is attached
> 
> LGTM - pushed. However, there were still whitespace
> errors that I had to fix. If you're not going to use
> vim please learn to flag whitespace errors in whatever
> editor you are currently using.

I've finally got to the bottom of your concerns here.  

A nearby line had a whitespace error, which is why neither 
git rebase --whitespace=fix nor tests.samba.source found the issue for
me. 

Thanks for fixing that up.

Andrew Bartlett

-- 
Andrew Bartlett
https://samba.org/~abartlet/
Authentication Developer, Samba Team         https://samba.org
Samba Development and Support, Catalyst IT   
https://catalyst.net.nz/services/samba









More information about the samba-technical mailing list