[PATCH] Fix bug 10634?

[Jeremy Allison]

On Fri, Oct 16, 2015 at 03:27:48PM -0700, Jeremy Allison wrote:
> On Fri, Oct 16, 2015 at 04:51:15PM +0200, Volker Lendecke wrote:
> > Hi!
> > 
> > Private autobuild is still running, but the attached patch seems pretty
> > obvious to me. Windows at least is happy with it.
> > 
> > Review appreciated!
> 
> OK - this one fixes make test for me.
> 
> The problem was your patch fixed the filename length,
> which revealed a hidden bug with 4-byte alignment
> (doubling the 16-bit size made it always 4 byte
> aligned, even though we're hand-assembling this
> by pushing blobs).
> 
> Please review and push if you're happy !

Hmmm. After thinking about it some the :

		[flag(NDR_ALIGN4)]    DATA_BLOB _pad;

shouldn't really have the "[flag(NDR_ALIGN4)]"
attribute. Doesn't do any good where I put it.

Updated patch with that removed attached !

Still passes make test.

Jeremy.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-smbd-Fix-file-name-buflen-and-padding-in-notify-reps.patch
Type: text/x-diff
Size: 2069 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151016/f44f2c2f/0001-smbd-Fix-file-name-buflen-and-padding-in-notify-reps.diff>