[PATCH] Fix bug #11555 - lookup_names() looks up qualified names as unqualified.

Jeremy Allison jra at samba.org
Thu Oct 15 16:04:07 UTC 2015


On Thu, Oct 15, 2015 at 09:09:45AM +0300, Uri Simchoni wrote:
> The use of the "NT Authority" literal string got me suspicious :)
> 
> I think this code would accept "NT Authority\Creator Group" and
> translate it into "\Creator Group" with a SID that's not "NT
> Authority".

Oh *wonderful* catch. That's a bug that's been there
forever :-).

> I would also be happier if:
> 1. The handling of NT Authority was placed next to the builtin stuff
> - put the builtin and well known near each other - they are almost
> the same from the perspective of most of the code and where I see
> builtin I also wonder about well-known.
> 2. The bug description doesn't contain anything from user's
> perspective. Is it possible to add some wording on what was the
> problem? (seems like some issues with the Windows security tab and
> the "Check Names" button...)

I'll take a look at Ralph's fix !



More information about the samba-technical mailing list