[PATCH] Fix bug #11555 - lookup_names() looks up qualified names as unqualified.

Uri Simchoni uri at samba.org
Thu Oct 15 06:09:45 UTC 2015


The use of the "NT Authority" literal string got me suspicious :)

I think this code would accept "NT Authority\Creator Group" and 
translate it into "\Creator Group" with a SID that's not "NT Authority".

I would also be happier if:
1. The handling of NT Authority was placed next to the builtin stuff - 
put the builtin and well known near each other - they are almost the 
same from the perspective of most of the code and where I see builtin I 
also wonder about well-known.
2. The bug description doesn't contain anything from user's perspective. 
Is it possible to add some wording on what was the problem? (seems like 
some issues with the Windows security tab and the "Check Names" button...)

Thanks,
Uri.

On 10/15/2015 02:32 AM, Jeremy Allison wrote:
> This was an interesting one found by Justin @ Netgear
> who had "winbind use default domain" set on a machine
> that was standalone :-).
>
> Justin confirmed the fix works for him.
>
> Passes a local make test (which took a while and a couple
> of extra changes to get it to pass, showing we're testing
> the codepaths here in standalone, NT and AD-DC mode :-).
>
> Please review + push if happy !
>
> Jeremy.




More information about the samba-technical mailing list