Tests for Andrew's talloc security work
Stefan Metzmacher
metze at samba.org
Fri Oct 9 04:19:50 UTC 2015
Am 09.10.2015 um 04:39 schrieb Adrian Cochrane:
> Here's my updated patches. Andrew reviewed them and I incremented the
> talloc version to 2.1.4 instead of 2.2.3 (as it was in the previous
> versions of my patches).
>
> On Fri, Oct 2, 2015 at 8:59 AM, Stefan Metzmacher <metze at samba.org> wrote:
>> Am 01.10.2015 um 20:17 schrieb Jeremy Allison:
>>> On Fri, Sep 11, 2015 at 02:52:46PM +1200, Adrian Cochrane wrote:
>>>> This update to my patches fixes a problem with the test asserting
>>>> that two
>>>> different processes use different talloc magic which prevented it from
>>>> running. Apologies for not alerting you to the problem earlier.
>>>>
>>>> I further want to point out that there's already a test asserting
>>>> Talloc
>>>> works across threads and of-course these patches pass it. While
>>>> this is a
>>>> simple test it does indicate these updates are thread safe.
>>>>
>>>> Thanks again,
>>>> Adrian Cochrane
>>>
>>> OK, finally got the chance to fully test these
>>> with a modern valgrind.
>>>
>>> There are a few whitespace errors at the end
>>> of lines that need fixing, plus patches 0004,
>>> 0005, 0006, 0007 need a 'Reviewed-by:' from
>>> Andrew.
>>>
>>> But other than that this looks GREAT !!!!
>>>
>>> Reviewed-by: Jeremy Allison <jra at samba.org>
>>>
>>> Congratulations, these are a great (and
>>> thread-safe :-) addition to talloc
>>> security !
>>
>> I'll pick that for the next talloc release (I hope next week).
Sorry, this will be delayed by 1 or 2 weeks.
metze
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151009/22c49976/signature.sig>
More information about the samba-technical
mailing list