Patch: Move the handling of svhdx to vfs_default.c

[Richard Sharpe]

On Fri, Oct 2, 2015 at 3:33 PM, Jeremy Allison <jra at samba.org> wrote:
> On Thu, Oct 01, 2015 at 08:06:44PM -0500, Steve French wrote:
>> Why do we return an error when we don't recognize a create context
>> (rather than just ignore it as Microsoft servers do)?
>>
>> MS-SMB2 says the following (and obviously Windows ignores AAPL rather
>> than returning an error, so unknown contexts can or should be ignored)
>>
>> "<247> Section 3.3.5.9: Windows Vista SP1, Windows Server 2008,
>> Windows 7, Windows Server 2008 R2, Windows 8, and Windows Server 2012
>> ignore create contexts having a NameLength greater than 4 and ignore
>> create contexts with a length of 4 that are not specified "
>>
>> HyperV in creating a VM (at least from Windows 10 MMC) fails on the
>> open/create of the image over SMB3 due to us returning
>> INVALID_DEVICE_REQUEST due to the unrecognized create context (for
>> SVHDXOpenDeviceContext).  This is not actually running the VM, just
>> creating an image file on a share.
>
> As far as I can see in current master code we don't
> complain about unrecognized create contexts, we just
> ignore them as we should.
>
> What Samba version were you running and can you give
> me a level 10 log of the failure ?

Except for this code that I moved from source3/smbd/smb2_create:

        if (svhdx != NULL) {
                /* SharedVHD is not yet supported */
                DEBUG(10, ("Shared VHD not yet supported,
INVALID_DEVICE_REQUEST\n"));
                return NT_STATUS_INVALID_DEVICE_REQUEST;
        }

https://www.youtube.com/watch?v=HjK30nhy7CU :-)

-- 
Regards,
Richard Sharpe
(何以解憂？唯有杜康。--曹操)