[PATCH] loadparm: Do not talloc empty params

Volker Lendecke Volker.Lendecke at SerNet.DE
Fri Nov 27 12:32:17 UTC 2015


On Fri, Nov 27, 2015 at 09:30:45AM +0100, Stefan Metzmacher wrote:
> Hi Volker,
> 
> Am 27.11.2015 um 07:41 schrieb Volker Lendecke:
> > On Thu, Nov 26, 2015 at 09:26:26PM +0100, Volker Lendecke wrote:
> >> On Thu, Nov 26, 2015 at 09:09:12PM +0100, Volker Lendecke wrote:
> >>> Hi!
> >>>
> >>> Review appreciated!
> >>
> >> Survived autobuild, but obviously buggy. More later.
> > 
> > This is better I think.
> > 
> > Review appreciated!
> 
> What about doing this "" to NULL handling within lpcfg_string_set()
> instead of just one caller.
> 
> We could do the same in lpcfg_string_set_upper() in order to be
> consistent...

Won't work, with such a patch samba.docs fails.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list