[PATCH] ctdb protocol fixes
martin at meltin.net
Wed Nov 25 01:03:54 UTC 2015
On Tue, 24 Nov 2015 16:55:15 -0800, Jeremy Allison <jra at samba.org>
> On Wed, Nov 25, 2015 at 11:47:36AM +1100, Martin Schwenke wrote:
> > On Tue, 24 Nov 2015 16:38:44 -0800, Jeremy Allison <jra at samba.org>
> > wrote:
> > > On Wed, Nov 25, 2015 at 11:34:45AM +1100, Martin Schwenke wrote:
> > > [...]
> > >
> > > No that's fine.
> > >
> > >
> > > You can always just change the ctdb_sock_addr_to_string() interface
> > > with an additional patch on top. If I'm right it shouldn't change
> > > much other code.
> > I tried this out. I added a "const" to the return value and dropped
> > the discard_const(). It seems that simple - everything compiles, no
> > new warnings or errors...
> > I'm happy to re-push with that change or leave it as an additional
> > change... whatever... :-)
> Yay ! Ship it :-). Whichever way is easier for you.
I should add that after chatting with Amitay I updated commit #3 in the
series to do what it says. That is, actually take out:
Thought I'd mentioned it since it now carries your Reviewed-by: ;-)
peace & happiness,
More information about the samba-technical