[PATCH] ctdb protocol fixes
jra at samba.org
Wed Nov 25 00:21:44 UTC 2015
On Tue, Nov 24, 2015 at 05:37:16PM +1100, Amitay Isaacs wrote:
> This include fixes to marshaling some of the data structures. (This is a
> subset of patches posted previously.)
> Please review and push.
Just one quick comment, shouldn't:
Subject: [PATCH 04/10] ctdb-protocol: Add utility function
make ctdb_sock_addr_to_string() return a const char *,
not a char * ?
All the places I see currently using ctdb_addr_to_str()
would work with a const char *, and don't need a char *.
I just get nervous when I see:
But this is not a blocker (just trying to keep the
code clean :-).
More information about the samba-technical