ldb bug fixes

Adrian Cochrane adrianc at catalyst.net.nz
Tue Nov 24 20:23:19 UTC 2015

It is ltdb_filter_attrs, the function I'm trying to patch. So you think 
I should remove this NULL check?

On Tue, Nov 24, 2015 at 6:44 PM, Volker Lendecke 
<Volker.Lendecke at SerNet.DE> wrote:
> On Tue, Nov 24, 2015 at 10:26:59AM +1300, Adrian Cochrane wrote:
>>  The intent is not to prevent msg->elements from being NULL, but to
>>  prevent the function from treating that as an error.
> Ok, so there *is* a place somewhere else that checks for
> msg->elements==NULL and treats it as an error?
> Sorry to be picky, but this kind of array/memory logic is
> always confusing, and in such lowlevel code we should really
> try to avoid confusion.
> Volker
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list