ldb bug fixes

Adrian Cochrane adrianc at catalyst.net.nz
Mon Nov 23 21:38:09 UTC 2015

Here's an updated patch I've hinted at

On Tue, Nov 24, 2015 at 10:26 AM, Adrian Cochrane 
<adrianc at catalyst.net.nz> wrote:
> The intent is not to prevent msg->elements from being NULL, but to 
> prevent the function from treating that as an error.
> On Tue, Nov 24, 2015 at 10:15 AM, Volker Lendecke 
> <Volker.Lendecke at SerNet.DE> wrote:
>> On Tue, Nov 24, 2015 at 09:15:36AM +1300, Adrian Cochrane wrote:
>>>  I am not aware of anywhere outside this function (which 
>>> specifically
>>>  errors out in the NULL case) that would have a problem with
>>>  msg->elements being NULL. I'll send another variant of the patch
>>>  shortly which sets msg->elements to that if it will please you.
>> I'm asking because you have a special if-clause for num_elements==0 
>> to
>> make sure that in that case msg->elements!=NULL. I would like to know
>> why this is necessary.
>> Thanks,
>> Volker
>> --
>> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
>> phone: +49-551-370000-0, fax: +49-551-370000-9
>> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
>> http://www.sernet.de, mailto:kontakt at sernet.de
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-ldb-Fix-bug-triggered-by-having-an-empty-message-in-.patch
Type: text/x-patch
Size: 3926 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151124/c8785e4b/0001-ldb-Fix-bug-triggered-by-having-an-empty-message-in-.bin>

More information about the samba-technical mailing list