ldb bug fixes

Adrian Cochrane adrianc at catalyst.net.nz
Mon Nov 23 21:25:34 UTC 2015

The check needs to be in there to prevent the error from being reported 
for empty messages or messages without any of the specified columns.

I could however rearrange the patch so the error check "msg->elements 
== NULL" is "msg->num_elements > 0 && msg->elements == NULL". That 
should do pretty much the same thing.

On Tue, Nov 24, 2015 at 10:15 AM, Volker Lendecke 
<Volker.Lendecke at SerNet.DE> wrote:
> On Tue, Nov 24, 2015 at 09:15:36AM +1300, Adrian Cochrane wrote:
>>  I am not aware of anywhere outside this function (which specifically
>>  errors out in the NULL case) that would have a problem with
>>  msg->elements being NULL. I'll send another variant of the patch
>>  shortly which sets msg->elements to that if it will please you.
> I'm asking because you have a special if-clause for num_elements==0 to
> make sure that in that case msg->elements!=NULL. I would like to know
> why this is necessary.
> Thanks,
> Volker
> --
> SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
> phone: +49-551-370000-0, fax: +49-551-370000-9
> AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
> http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list