[PATCHES] dbwrap_ctdb: Small cleanup

Christof Schmitt cs at samba.org
Thu Nov 19 17:27:20 UTC 2015


On Wed, Nov 18, 2015 at 10:20:52AM +0100, Stefan Metzmacher wrote:
> Hi Christof,
> 
> > diff --git a/source3/lib/dbwrap/dbwrap_ctdb.c b/source3/lib/dbwrap/dbwrap_ctdb.c
> > index 93df7ef..2bc86d2 100644
> > --- a/source3/lib/dbwrap/dbwrap_ctdb.c
> > +++ b/source3/lib/dbwrap/dbwrap_ctdb.c
> > @@ -557,9 +557,7 @@ static NTSTATUS db_ctdb_transaction_store(struct db_ctdb_transaction_handle *h,
> >  {
> >  	TALLOC_CTX *tmp_ctx = talloc_new(h);
> >  	TDB_DATA rec;
> > -	struct ctdb_ltdb_header header;
> > -
> > -	ZERO_STRUCT(header);
> > +	struct ctdb_ltdb_header header = { 0 };
> >  
> >  	/* we need the header so we can update the RSN */
> 
> We can't change this because it doesn't initialize possible
> padding within the structure and we later memcpy it into
> the stored record.

Ok. Then let's just drop this.

Christof



More information about the samba-technical mailing list