[PATCH] CTDB protocol and client fixes

Stefan Metzmacher metze at samba.org
Thu Nov 19 08:36:53 UTC 2015

Hi Amitay,

> Here are the changes to the new protocol and client code.
> Many of them are fixes required for the rewrite of ctdb tool and test
> binaries using new client API.
> Major changes to protocol code include:
> 1. Fix marshaling of data types ctdb_addr_info, ctdb_public_ip_list,
> ctdb_rec_data
> 2. Add utility function ctdb_sock_addr_to_string
> Major changes to client code include:
> 1. Avoid using sync functions in async computations (tevent_req  based)
> 2. Add missing sync/async versions of some of the APIs
> 3. Drop TALLOC_CTX where not required

Can you also remove the 'struct tevent_context *ev' argument from all
sync functions? They should create a temporary event context,
see smb2cli_echo() and others as example.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151119/b4dd6fbe/signature.sig>

More information about the samba-technical mailing list