[PATCH] Some fixes from trying to build on OpenBSD
rb at sernet.de
Wed Nov 18 15:18:03 UTC 2015
On Wed, Nov 18, 2015 at 04:10:27PM +0100, Volker Lendecke wrote:
> On Wed, Nov 18, 2015 at 04:07:05PM +0100, Ralph Boehme wrote:
> > Hi!
> > On Wed, Nov 18, 2015 at 02:55:33PM +0100, Volker Lendecke wrote:
> > > Unfortunately the patch breaks on sn-devel. We need
> > > memalign. On OpenBSD this does not exist, so libreplace
> > > replaces it. The wscript test in libreplace only checks
> > > whether memalign can link. Unfortunately in glibc memalign
> > > comes from malloc.h.
> > >
> > > Attached find a new patch.
> > >
> > > Review appreciated!
> > can we squash the malloc and the memalign commmit?
> > I'd also add a check whether el_size is 0 to the last commit.
> Ok, fine.
> > Updated patchset attached, feel free to push.
> > Btw, what about the memalign check in source3/wscript?
> lib/replace provides a memalign replacement. That's why I
> put it there.
That was my thought too. But then, why do we have it in
source3/wscript? Shouldn't we remove it there and have callers pull in
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
More information about the samba-technical