[PATCH] Some fixes from trying to build on OpenBSD

Volker Lendecke Volker.Lendecke at SerNet.DE
Wed Nov 18 15:10:27 UTC 2015


On Wed, Nov 18, 2015 at 04:07:05PM +0100, Ralph Boehme wrote:
> Hi!
> 
> On Wed, Nov 18, 2015 at 02:55:33PM +0100, Volker Lendecke wrote:
> > Unfortunately the patch breaks on sn-devel. We need
> > memalign. On OpenBSD this does not exist, so libreplace
> > replaces it. The wscript test in libreplace only checks
> > whether memalign can link. Unfortunately in glibc memalign
> > comes from malloc.h.
> > 
> > Attached find a new patch.
> > 
> > Review appreciated!
> 
> can we squash the malloc and the memalign commmit?

Sure.

> 
> I'd also add a check whether el_size is 0 to the last commit.

Ok, fine.

> Updated patchset attached, feel free to push.
> 
> Btw, what about the memalign check in source3/wscript?

lib/replace provides a memalign replacement. That's why I
put it there. Current BSDs also have posix_memalign. We
might consider just removing the memalign replacement and
caller.

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de



More information about the samba-technical mailing list