[PATCH] Some fixes from trying to build on OpenBSD

Jérémie Courrèges-Anglas jca at wxcvbn.org
Mon Nov 16 18:43:26 UTC 2015


"Thomas Nagy" <tnagy at waf.io> writes:

> On Mon, 16 Nov 2015 16:53:15 +0100, Volker Lendecke wrote:
>
>> Hi!

Hi folks,

>> Review&push appreciated!
>> 
>
> The new "malloc.h" test is wrapped by:
>     if not conf.CHECK_DECLS('malloc', headers='stdlib.h'):
> in one place, but not in the other. Is that intentional?

After applying all patches, I can only see one
"conf.CHECK_HEADERS('malloc.h')" occurrence in lib/replace/wscript,
which looks correct to me.  The OpenBSD samba port already patches the
malloc.h include in order to get readable build logs.

Regarding the clusapi.idl patch: I guess you encountered the same issue
as I did.  The patches would probably make sense, but the underlying
issue is that /usr/bin/cpp is a shell script that calls the
/usr/libexec/cpp with flags to make it behave as a "traditional" (ie.
dumb) C preprocessor.  IIRC pointing CPP at /usr/libexec/cpp was enough
to get those .idl files parsed correctly, but I guess that restricting
the syntax used by .idl files is a valid option too. :)

-- 
jca | PGP : 0x1524E7EE / 5135 92C1 AD36 5293 2BDF  DDCC 0DFA 74AE 1524 E7EE



More information about the samba-technical mailing list