[PATCH] CTDB logging (debug level) cleanups
obnox at samba.org
Sun Nov 15 21:45:01 UTC 2015
On 2015-11-13 at 20:43 +1100, Amitay Isaacs wrote:
> On Fri, Nov 13, 2015 at 5:33 PM, Michael Adam <obnox at samba.org> wrote:
> > On 2015-11-13 at 16:03 +1100, Martin Schwenke wrote:
> > > On Fri, 13 Nov 2015 14:34:54 +1100, Amitay Isaacs <amitay at gmail.com>
> > > wrote:
> > >
> > > > This patch set gets rid of common/ctdb_logging.c and
> > include/ctdb_logging.h
> > > > (eventually!).
> > > >
> > > > This is achieved by moving code used only in the daemon to server/
> > > > directory.
> > > >
> > > > Please review and push.
> > >
> > > Reviewed-by: Martin Schwenke <martin at meltin.net>
> > >
> > > Will wait to see if anyone else wants to take a look too... :-)
> > This looks like a greate cleanup.
> > Only comment:
> > Those patches that let the code use the new debug_level api
> > also change the include to the new common/logging.h.
> > I had somehow expected these hunks to be already included
> > in the previous seeping change patches.
> > Was there a special reason to hold these off?
> > Michael
> This is part of the progressive clean up.
> The first step was to create new standalone abstractions that helped
> implement parallel database recovery. Next step was to clean up the
> includes to avoid unnecessary cross-dependencies between all parts of ctdb
> client/server code.
> Eventually I want to replace the old client code with new client API
> wherever possible. This includes ctdb tool and all of the test binaries.
> We cannot get rid of the older client code completely just yet since it is
> very much used in the child processes created by ctdb daemon (including
> recovery daemon). That will go away only when we separate various
> daemons. As you would have noticed Martin is working on separating cluster
> operations and IP allocation from recovery daemon.
> To be able to re-implement ctdb tool using new client API, I need to be
> re-use some of the existing code defined in ctdb-system subsystem. This
> set of patches will help to get rid of more inter-dependencies between
> various (build) subsystems and make them standalone. I have already
> re-implemented ctdb tool using new client API and working on getting tests
> to work with the new tool.
OK, thanks for the explanations.
My question was much more basic and cosmetic. :-)
-------------- next part --------------
A non-text attachment was scrubbed...
Size: 198 bytes
Desc: not available
More information about the samba-technical