[PATCHES] Issue fsync for SMB2 FLUSH asynchronously

[Jeremy Allison]

On Fri, Nov 13, 2015 at 11:51:25AM -0700, Christof Schmitt wrote:
> 
> Probably we should also update the documentation for 'strict sync' and
> mention the changes in WHATSNEW. See attached patches.

LGTM - pushed ! Thanks.

> From 9f2cee9674e46dc0f0f375d137ce5e4eacf82f5f Mon Sep 17 00:00:00 2001
> From: Christof Schmitt <cs at samba.org>
> Date: Fri, 13 Nov 2015 11:46:33 -0700
> Subject: [PATCH 1/2] docs: Update doc for 'strict sync' parameter for async SMB2 flush
> 
> Signed-off-by: Christof Schmitt <cs at samba.org>
> ---
>  docs-xml/smbdotconf/tuning/strictsync.xml |    6 +++++-
>  1 files changed, 5 insertions(+), 1 deletions(-)
> 
> diff --git a/docs-xml/smbdotconf/tuning/strictsync.xml b/docs-xml/smbdotconf/tuning/strictsync.xml
> index 0d33845..5cfd388 100644
> --- a/docs-xml/smbdotconf/tuning/strictsync.xml
> +++ b/docs-xml/smbdotconf/tuning/strictsync.xml
> @@ -5,7 +5,7 @@
>   <description>
>      <para>Many Windows applications (including the Windows 98 explorer
>      shell) seem to confuse flushing buffer contents to disk with doing
> -    a sync to disk. Under UNIX, a sync call forces the process to be
> +    a sync to disk. Under UNIX, a sync call forces the thread to be
>      suspended until the kernel has ensured that all outstanding data in
>      kernel disk buffers has been safely stored onto stable storage.
>      This is very slow and should only be done rarely. Setting this
> @@ -17,6 +17,10 @@
>      on crashes, so there is little danger in this default setting. In
>      addition, this fixes many performance problems that people have
>      reported with the new Windows98 explorer shell file copies.</para>
> +    <para>The flush request from SMB2/3 clients is handled
> +    asynchronously, so for these clients setting the parameter
> +    to <constant>yes</constant> does not block the processing of other
> +    requests in the smbd process.</para>
>  </description>
>  
>  <related>sync always</related>
> -- 
> 1.7.1
> 
> 
> From 56a82195b5d4f944e9e759c3e6cab95eef4a9fd2 Mon Sep 17 00:00:00 2001
> From: Christof Schmitt <cs at samba.org>
> Date: Fri, 13 Nov 2015 11:47:32 -0700
> Subject: [PATCH 2/2] WHATSNEW: Add async SMB2 flush and new aio parameter
> 
> Signed-off-by: Christof Schmitt <cs at samba.org>
> ---
>  WHATSNEW.txt |    6 ++++++
>  1 files changed, 6 insertions(+), 0 deletions(-)
> 
> diff --git a/WHATSNEW.txt b/WHATSNEW.txt
> index d76d8fc..f1a1c07 100644
> --- a/WHATSNEW.txt
> +++ b/WHATSNEW.txt
> @@ -17,6 +17,11 @@ Nothing special.
>  NEW FEATURES
>  ============
>  
> +Flush requests from SMB2/3 clients are handled asynchronously and do
> +not block the processing of other requests. Note that 'strict sync'
> +has to be set to 'yes' for Samba to honor flush requests from SMB
> +clients.
> +
>  WINS nsswitch module
>  ====================
>  
> @@ -34,6 +39,7 @@ smb.conf changes
>  
>    Parameter Name		Description		Default
>    --------------		-----------		-------
> +  aio max threads               New                     100
>  
>  KNOWN ISSUES
>  ============
> -- 
> 1.7.1
>