[PATCH] CTDB logging (debug level) cleanups

Michael Adam obnox at samba.org
Fri Nov 13 06:33:19 UTC 2015

On 2015-11-13 at 16:03 +1100, Martin Schwenke wrote:
> On Fri, 13 Nov 2015 14:34:54 +1100, Amitay Isaacs <amitay at gmail.com>
> wrote:
> > This patch set gets rid of common/ctdb_logging.c and include/ctdb_logging.h
> > (eventually!).
> > 
> > This is achieved by moving code used only in the daemon to server/
> > directory.
> > 
> > Please review and push.
> Reviewed-by: Martin Schwenke <martin at meltin.net>
> Will wait to see if anyone else wants to take a look too...  :-)

This looks like a greate cleanup.

Only comment:

Those patches that let the code use the new debug_level api
also change the include to the new common/logging.h.

I had somehow expected these hunks to be already included
in the previous seeping change patches.

Was there a special reason to hold these off?

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151113/0c8c4506/signature.sig>

More information about the samba-technical mailing list