[PATCH] lib: Fix CID 1338432 Unchecked return value

Michael Adam obnox at samba.org
Wed Nov 11 07:39:19 UTC 2015

On 2015-11-10 at 11:47 -0800, Jeremy Allison wrote:
> On Tue, Nov 10, 2015 at 08:39:51PM +0100, Volker Lendecke wrote:
> > On Tue, Nov 10, 2015 at 09:27:58AM -0800, Jeremy Allison wrote:
> > > Volker, please stop treating anyone commenting
> > > on your code as a human rights violation that
> > > requires a revert of a perfectly good autobuild.
> > 
> > This (and other) patches are just not important enough to spend time
> > discussing them. There are much more important arguments to have.
> I understand your feelings on that - I agree there
> are more important discussions. Sometimes these things
> can feel like bike-shedding:
> https://en.wikipedia.org/wiki/Parkinson's_law_of_triviality
> But getting frustrated and cancelling things isn't
> the right answer.

Correct. IMHO every patch, trivial or not, deserves to be
questioned. If you want to avoid getting drawn into discussions
about trivial things but want to concentrate about the
'important' things instead, then the solution is trivial: simply
don't propose patches for stuff that you feel is not important.

Despite your claim to not want to waste people's time, Volker,
this propose-withdraw behaviour wastes a lot more time of a lot
more people than allowing technical discussions even for
seemingly trivial patches ever could. :-)

And in this case it was not 100% trivial even.  The question was
justified. And a single reply or two could have just explained
your deeper motivations.

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151111/e735d225/signature.sig>

More information about the samba-technical mailing list