[PATCH] lib: Fix CID 1338432 Unchecked return value

Jeremy Allison jra at samba.org
Tue Nov 10 19:47:39 UTC 2015

On Tue, Nov 10, 2015 at 08:39:51PM +0100, Volker Lendecke wrote:
> On Tue, Nov 10, 2015 at 09:27:58AM -0800, Jeremy Allison wrote:
> > Volker, please stop treating anyone commenting
> > on your code as a human rights violation that
> > requires a revert of a perfectly good autobuild.
> This (and other) patches are just not important enough to spend time
> discussing them. There are much more important arguments to have.

I understand your feelings on that - I agree there
are more important discussions. Sometimes these things
can feel like bike-shedding:


But getting frustrated and cancelling things isn't
the right answer. I always try and remember that
everyone commenting is trying to do the right thing
and improve the code, even if they sometimes drive
me nuts :-).

It helps get along with everyone in the long run.
And if it really is bike-shedding, then eventually
someone will just push it for you after getting
tired of the discussion (which would have happened
in this case if you'd just ignored the comment :-).

On another note - have you seen this ?


Very interesting view of kernel security policy
(even if it is presented in Theo's inimitable
style :-).

I especially like:

"Optional Security is Irrelevent"




More information about the samba-technical mailing list