[PATCH] lib: Fix CID 1338432 Unchecked return value
rb at sernet.de
Tue Nov 10 18:13:08 UTC 2015
On Tue, Nov 10, 2015 at 10:04:08AM -0800, Jeremy Allison wrote:
> On Tue, Nov 10, 2015 at 07:54:54PM +0200, Uri Simchoni wrote:
> > >>>On Tue, Nov 10, 2015 at 11:29:41AM +0200, Uri Simchoni wrote:
> > >>here is the correct decision.
> > >One of the nice things about abort() is that it will trigger the
> > >backtrace handler etc, which is essentially ideal for describing this
> > >kind of error, and that handler can and does trigger DEBUG().
> > >
> > >Andrew Bartlett
> > >
> > abort() is great and that's what should be done, but the vital piece
> > of information is - what was the return value of pthread_join()? For
> > this I wanted a debug message.
> Yeah but we can't get there from here :-).
> Doing abort() and letting a crash dump
> figure it out is the best we can do here.
> If the pthread_join fails then we're probably
> in such a bad state that trying a debug
> is unsafe and could make things worse.
> Die and let the post-mortem figure it
> out IMHO :-).
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
More information about the samba-technical