[PATCH] Trim down remove_child_pid()

Ralph Boehme rb at sernet.de
Tue Nov 10 18:00:34 UTC 2015


On Mon, Nov 09, 2015 at 04:14:38PM +0100, Volker Lendecke wrote:
> This is the one where part of my latest patch stream comes
> from: We need to trim down remove_child_pid() to its barely
> necessary minimum. In particular, we need to avoid that the
> parent smbd has to talk to ctdbd, if possible at all.
> We've had the case where the smb listener was stuck for
> ages, because ctdb was busy. We can't allow this to happen.
> The attached patchset implements a helper process that does
> all the dirty work at process exit that remove_child_pid
> did.
> In theory, we should also remove the 20-second thingy, but
> that does not really hurt and would be something for another
> day.
> Comments?

very nice! One question:

> Subject: [PATCH 6/7] smbd: Send MSG_SMB_UNLOCK to children
> Walking our in-memory child list is cheaper than traversing serverid.tdb,
> and all who care are the smbd children

message_send_all() in cleanupd may be more expensive then
messaging_send_to_children() in the parent, but the latter is possibly
still significant work while the former takes place in a mostly idle

Moving cleanup_timeout_fn() to cleanupd seems like the way to do it.

Besides that, all reviewed by me.


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen

More information about the samba-technical mailing list