[PATCH] lib: Fix CID 1338432 Unchecked return value

Jeremy Allison jra at samba.org
Tue Nov 10 17:27:58 UTC 2015

On Tue, Nov 10, 2015 at 10:36:38AM +0100, Volker Lendecke wrote:
> On Tue, Nov 10, 2015 at 11:29:41AM +0200, Uri Simchoni wrote:
> > On 11/10/2015 11:20 AM, Ralph Boehme wrote:
> > >On Tue, Nov 10, 2015 at 10:01:02AM +0100, Volker Lendecke wrote:
> > >>Review&push appreciated!
> > >pushed.
> > >
> > >-Ralph
> > >
> > What about printing a decent error message if it does happen? (for
> > example, someone stomps over the pool object, causing a call to
> > pthread_join with garbage thread id)
> > 
> > I can see the pthreadpool code currently does not include debug.h,
> > maybe for dependency reasons, but IMHO you want an error message
> > printed when a system call fails unexpectedly.
> Ok, we better leave this unpatched. I don't want to touch
> anything like DEBUG or even printf or syslog in anything
> that even from a distance touches threads.
> Sorry for the noise, Volker

No, *not* better to leave this unpatched. abort()
here is the correct decision.

Volker, please stop treating anyone commenting
on your code as a human rights violation that
requires a revert of a perfectly good autobuild.

It's childish and prevents your code from getting
proper review as people start to dread your overreactions.

That's not professional software development which
we're all striving for here.

I will re-push the fix.



More information about the samba-technical mailing list