[PATCH] lib: Fix CID 1338432 Unchecked return value

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Nov 10 09:36:38 UTC 2015

On Tue, Nov 10, 2015 at 11:29:41AM +0200, Uri Simchoni wrote:
> On 11/10/2015 11:20 AM, Ralph Boehme wrote:
> >On Tue, Nov 10, 2015 at 10:01:02AM +0100, Volker Lendecke wrote:
> >>Review&push appreciated!
> >pushed.
> >
> >-Ralph
> >
> What about printing a decent error message if it does happen? (for
> example, someone stomps over the pool object, causing a call to
> pthread_join with garbage thread id)
> I can see the pthreadpool code currently does not include debug.h,
> maybe for dependency reasons, but IMHO you want an error message
> printed when a system call fails unexpectedly.

Ok, we better leave this unpatched. I don't want to touch
anything like DEBUG or even printf or syslog in anything
that even from a distance touches threads.

Sorry for the noise, Volker

SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list