[PATCH] lib: Fix CID 1338432 Unchecked return value

Uri Simchoni uri at samba.org
Tue Nov 10 09:29:41 UTC 2015

On 11/10/2015 11:20 AM, Ralph Boehme wrote:
> On Tue, Nov 10, 2015 at 10:01:02AM +0100, Volker Lendecke wrote:
>> Review&push appreciated!
> pushed.
> -Ralph
What about printing a decent error message if it does happen? (for 
example, someone stomps over the pool object, causing a call to 
pthread_join with garbage thread id)

I can see the pthreadpool code currently does not include debug.h, maybe 
for dependency reasons, but IMHO you want an error message printed when 
a system call fails unexpectedly.


More information about the samba-technical mailing list