ctdb/wscript: Avoid installing pre-built man pages which does not exist during make

[Michael Adam]

On 2015-11-10 at 15:14 +1100, Martin Schwenke wrote:
> Hi Anoop,
> 
> On Mon, 09 Nov 2015 18:13:54 +0530, Anoop C S
> <anoopcs at redhat.com> wrote:
> 
> > When samba is compiled from source with-cluster-support, make fails
> > with the following warning in the absence of xsltproc:
> > 
> > input file 'doc/ctdb.1' could not be found ('/root/samba/ctdb')
> > 
> > This is because in ctdb/wscript we try to install pre-built ctdb man
> > pages which does not exist under ctdb/doc if XSLTPROC_MANPAGES is not
> > set during configure as follows:
> > 
> > if 'XSLTPROC_MANPAGES' in bld.env and bld.env['XSLTPROC_MANPAGES']:
> >     bld.MANPAGES('''onnode.1 ctdbd_wrapper.1 ctdbd.conf.5
> >                  ctdb.7 ctdb-statistics.7 ctdb-tunables.7''',
> >                  True)
> > else:
> >     for m in manpages:                                     
> >         bld.SAMBA_GENERATOR(m,
> >                          source=os.path.join("doc", m),
> >                          target=m,
> >                          rule='sed %s ${SRC} > ${TGT}' % (sed_cmdline))
> >         bld.INSTALL_FILES('${MANDIR}/man%s' % m[-1], m)
> > 
> > On a fedora 23 machine docbook-style-xsl provides the necessary style
> > sheets to convert xml docs to required formats.
> 
> I don't know what this last sentence means.  It isn't enough to install
> the stylesheets.  To be able to use them you also need to install
> xsltproc, right?  In Red Hat that's in the libxslt package...
> 
> So, yes, there is a bug... but I don't know what you mean... I'm
> wondering why you didn't install xsltproc to work around it.  :-)

Anoop's situation (which we debugged together) was that he had
xsltproc installed, but the docbook-style-xsl pkg was missing.
Essentially a yum-builddep samba fixed the situation and we
hunted down what had been missing before.

But imagine: If he had been installing the full deps from the
start, then we may not have found the bug. ;-)

Cheers - Michael
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151110/1c705729/signature.sig>