[PATCH] Trim down remove_child_pid()

[Volker Lendecke]

On Mon, Nov 09, 2015 at 07:05:44PM +0100, Ralph Boehme wrote:
> Hi Volker,
> 
> On Mon, Nov 09, 2015 at 04:14:38PM +0100, Volker Lendecke wrote:
> > This is the one where part of my latest patch stream comes
> > from: We need to trim down remove_child_pid() to its barely
> > necessary minimum. In particular, we need to avoid that the
> > parent smbd has to talk to ctdbd, if possible at all.
> > 
> > We've had the case where the smb listener was stuck for
> > ages, because ctdb was busy. We can't allow this to happen.
> > 
> > The attached patchset implements a helper process that does
> > all the dirty work at process exit that remove_child_pid
> > did.
> > 
> > In theory, we should also remove the 20-second thingy, but
> > that does not really hurt and would be something for another
> > day.
> > 
> > Comments?
> 
> reviewing...

Just figured out that the last patch has a bug:

-       messaging_send_buf(msg_ctx, messaging_server_id(msg_ctx),                                               
-                          MSG_SMB_BRL_VALIDATE, NULL, 0);                                                      
+       if (am_parent) {                                                                                        
+               messaging_send_buf(msg_ctx, parent->cleanupd,                                                   
+                                  MSG_SMB_BRL_VALIDATE, NULL, 0);                                              
+       }                                                                 

We need to send to am_parent->cleanupd, not
parent->cleanupd. I have no clue how this went through the
private autobuild. Can you change that directly?

Thanks,

Volker

-- 
SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de