ctdb/wscript: Avoid installing pre-built man pages which does not exist during make

[Anoop C S]

On Mon, 2015-11-09 at 16:30 +0100, Ralph Boehme wrote:
> On Mon, Nov 09, 2015 at 03:52:27PM +0100, Michael Adam wrote:
> > On 2015-11-09 at 18:13 +0530, Anoop C S wrote:
> > > Hi,
> > > 
> > > When samba is compiled from source with-cluster-support, make
> > > fails
> > > with the following warning in the absence of xsltproc:
> > > 
> > > input file 'doc/ctdb.1' could not be found ('/root/samba/ctdb')
> > > 
> > > This is because in ctdb/wscript we try to install pre-built ctdb
> > > man
> > > pages which does not exist under ctdb/doc if XSLTPROC_MANPAGES is
> > > not
> > > set during configure as follows:
> > > 
> > > if 'XSLTPROC_MANPAGES' in bld.env and
> > > bld.env['XSLTPROC_MANPAGES']:
> > >     bld.MANPAGES('''onnode.1 ctdbd_wrapper.1 ctdbd.conf.5
> > >                  ctdb.7 ctdb-statistics.7 ctdb-tunables.7''',
> > >                  True)
> > > else:
> > >     for m in manpages:                                     
> > >         bld.SAMBA_GENERATOR(m,
> > >                          source=os.path.join("doc", m),
> > >                          target=m,
> > >                          rule='sed %s ${SRC} > ${TGT}' %
> > > (sed_cmdline))
> > >         bld.INSTALL_FILES('${MANDIR}/man%s' % m[-1], m)
> > > 
> > > On a fedora 23 machine docbook-style-xsl provides the necessary
> > > style
> > > sheets to convert xml docs to required formats.
> > > 
> > > Attached is a patch which reverts the commit 3ddd3514 which
> > > introduced
> > > this else part in ctdb/wscript. Many thanks to Michael who helped
> > > me in
> > > finding the root cause.
> > 
> > Reviewed-by: me.
> 
> reviewed by me too, but not pushed as the patch is missing the
> signed-off.
> 
> Anoop, can you please add your signed-off to the patch and resubmit ?
> 

Resubmitting the patch with signed-off.

--Anoop C S

> -Ralph
> 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Revert-ctdb-build-Install-pre-built-manpages-when-xs.patch
Type: text/x-patch
Size: 1367 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151109/ac658add/0001-Revert-ctdb-build-Install-pre-built-manpages-when-xs.bin>