[PATCHES] Add support for CTDB volatile database in tmpfs
martin at meltin.net
Mon Nov 9 09:03:51 UTC 2015
On Mon, 9 Nov 2015 07:47:32 +0100, Michael Adam <obnox at samba.org> wrote:
> On 2015-11-09 at 14:27 +1100, Martin Schwenke wrote:
> > One supporting patch and then this...
> > ctdb-scripts: Add support for CTDB_DBDIR in tmpfs
> > The tmpfs is mounted and unmounted by ctdbd_wrapper. Format is
> > CTDB_DBDIR=tmpfs:<tmpfs-options>. The only default for the tmpfs is
> > mode=700 - to override, specify a different value in <tmpfs-options>.
> > There may be performance benefits...
> > Review and push appreciated...
> That is nice work, indeed!
> Just one comment:
> It catches me off guard again and again,
> that the /usr/local/... directories are
> hard-coded in the script and replaced by
> sed-magic from wscript ... ;-)
Yeah. I started with template strings (e.g. @@CTDB_VARDIR@@) but then
Amitay and I decided that the manpages should be reasonable by default
when they go into a tarball via "make dist". So, if you don't have
xsltproc then you would get the manpages installed from the tarball and
the defaults are fairly sane. Originally I decided that it was safer
to do sed magic on the XML, since I know what it looks like, and I
didn't want to play with the generated nroff files.
However, then we realised that without xlstproc installed, the manpages
weren't being installed at all. After some successful experimentation,
the fix for that included running the sed magic on the nroff files from
the tarball after all. :-)
At this stage it would be possible to go to template strings... but
you get used to the /usr/local/ thing... just think of them ask
template strings... ;-)
Oh, and the choice of /usr/local/-based defaults comes from an
observation a long time ago by "steve" that the default ./configure
prefix is /usr/local/, so why didn't our documentation match? He was
right... and now it does... it just took a while... :-)
> Reviewed-by: me
> Going to push.
peace & happiness,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 173 bytes
Desc: OpenPGP digital signature
More information about the samba-technical