[PATCH] A few cleanups

[Michael Adam]

Hi!

On 2015-11-08 at 20:34 +0100, Volker Lendecke wrote:
> Hi!
> 
> Review&push appreciated!

That looks good, just one question:

> From 2b645defccaa10874f64e203c1cba4fdc0965c0a Mon Sep 17 00:00:00 2001
> From: Volker Lendecke <vl at samba.org>
> Date: Fri, 6 Nov 2015 16:59:44 +0100
> Subject: [PATCH 3/6] lib: Move some procid functions out of util.c
> 
> Including proto.h just for pid_to_procid() is a pain...
> 
> Signed-off-by: Volker Lendecke <vl at samba.org>
> [...]
> diff --git a/source3/include/proto.h b/source3/include/proto.h
> index c2d9166..9dd08fb 100644
> --- a/source3/include/proto.h
> +++ b/source3/include/proto.h
> @@ -433,14 +433,11 @@ bool unix_wild_match(const char *pattern, const char *string);
>  bool name_to_fqdn(fstring fqdn, const char *name);
>  void *talloc_append_blob(TALLOC_CTX *mem_ctx, void *buf, DATA_BLOB blob);
>  uint32_t map_share_mode_to_deny_mode(uint32_t share_access, uint32_t private_options);
> -pid_t procid_to_pid(const struct server_id *proc);
> -void set_my_vnn(uint32_t vnn);
> -uint32_t get_my_vnn(void);
> -struct server_id pid_to_procid(pid_t pid);
> +
> +#include "lib/util_procid.h"
> +

With that we still include proto.h where we need
these procid functions. Wouldn't it be more
consistent to not include util_procid.h in proto.h?

Michael

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 198 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151109/e5b4b327/signature.sig>