[PATCH] some valgrind related patches

Jeremy Allison jra at samba.org
Thu Nov 5 01:22:20 UTC 2015


On Wed, Nov 04, 2015 at 02:48:51PM +0000, Noel Power wrote:
> > [PATCH 4/6]: Why not ZERO_STRUCT?
> why not indeed, done & changed
> > [PATCH 5/6]: I'd go with struct lock_struct lock = {0};
> > [PATCH 6/6]: ENOPATCH? :-)
> no, just 6/6 was not to do with this but instead some temporary patch to
> do with something unrelated
> 
> see new version(s) attached (with #if DEVELOPER removed)

Only problem is in 0002-fix-Invalid-read-of-size-1-in-reply_search.patch,

const char *mask = NULL

needs changing to:

char *mask = NULL

in order to get this to compile (otherwise the

+	TALLOC_FREE(mask);

fails with a const violation.

Can you repost a new set ?



More information about the samba-technical mailing list