smbtorture running same test twice

Jeremy Allison jra at samba.org
Wed Nov 4 22:37:24 UTC 2015


On Fri, Oct 23, 2015 at 11:33:47AM -0700, Jeremy Allison wrote:
> On Thu, Oct 22, 2015 at 08:11:05AM -0700, Herb Lewis wrote:
> > --- a/source4/torture/basic/delaywrite.c
> > +++ b/source4/torture/basic/delaywrite.c
> > @@ -3088,7 +3088,6 @@
> >      torture_suite_add_2smb_test(suite, "delayed update of write
> > time 5b", test_delayed_write_update5b);
> >      torture_suite_add_2smb_test(suite, "delayed update of write
> > time 6", test_delayed_write_update6);
> >      torture_suite_add_1smb_test(suite, "timestamp resolution test",
> > test_delayed_write_update7);
> > -    torture_suite_add_1smb_test(suite, "timestamp resolution test",
> > test_delayed_write_update7);
> >      torture_suite_add_1smb_test(suite, "directory timestamp update
> > test", test_directory_update8);
> > 
> >      return suite;
> 
> Can you add your 'Reviewed-by:' to this and I'll push ?

Ping Herb. You OK with this ?

> From f169f11805907a0f944e2d073335d2867c13c2f1 Mon Sep 17 00:00:00 2001
> From: Jeremy Allison <jra at samba.org>
> Date: Thu, 22 Oct 2015 16:36:09 -0700
> Subject: [PATCH] s4: torture: Don't run 'timestamp resolution test' twice.
> 
> Found by Herb Lewis <hlewis at panasas.com>
> 
> Signed-off-by: Jeremy Allison <jra at samba.org>
> ---
>  source4/torture/basic/delaywrite.c | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/source4/torture/basic/delaywrite.c b/source4/torture/basic/delaywrite.c
> index 67788f4..6541b2a 100644
> --- a/source4/torture/basic/delaywrite.c
> +++ b/source4/torture/basic/delaywrite.c
> @@ -3088,7 +3088,6 @@ struct torture_suite *torture_delay_write(void)
>  	torture_suite_add_2smb_test(suite, "delayed update of write time 5b", test_delayed_write_update5b);
>  	torture_suite_add_2smb_test(suite, "delayed update of write time 6", test_delayed_write_update6);
>  	torture_suite_add_1smb_test(suite, "timestamp resolution test", test_delayed_write_update7);
> -	torture_suite_add_1smb_test(suite, "timestamp resolution test", test_delayed_write_update7);
>  	torture_suite_add_1smb_test(suite, "directory timestamp update test", test_directory_update8);
>  
>  	return suite;
> -- 
> 2.6.0.rc2.230.g3dd15c0
> 




More information about the samba-technical mailing list