[PATCH] Fix bug #11589 - turning off EA's can create files incorrectly.

Jeremy Allison jra at samba.org
Wed Nov 4 18:35:11 UTC 2015


On Wed, Nov 04, 2015 at 08:25:04PM +0200, Uri Simchoni wrote:
> Pushed to autobuild. There are small holes in the scheme yet:
> - If the attribute is a samba private attribute, then the create
> fails but file gets created
> - If ea's are enabled and the underlying file system does not
> support them or otherwise fails to set them (e.g. >4K) - failure and
> file gets created.
> 
> To cover both these cases we can take care to delete the file if ea
> setting fails, which may prove to be surprisingly difficult to do
> without a race....

I already thought about and discarded that idea. It's just
about *impossible* to do without a race (no handle-based
delete in posix) so it's easier to live with the occassional
consequence.



More information about the samba-technical mailing list