[PATCHES] Port ldb to Python 3

Stefan Metzmacher metze at samba.org
Wed Nov 4 15:28:13 UTC 2015


Hi Petr,

there were two bugs in the patches which delayed the push to master.
They're fixed in
https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/heads/master3-python

Are you fine if I squash
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=6eefea2e8ebb676c49a8b8889717bc157cb34182
into
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=5ad73b5fed5afd0ac3e471100c87f5b8dcabd513

and
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=456260be657c3ce6146f4c6c98e2d7d1f36ddec5
into
https://git.samba.org/?p=metze/samba/wip.git;a=commitdiff;h=0441ff32f7ba8254cfeb4af409cbbcfabf1d7f31

metze

>>>>> Reviewed-by: Andrew Bartlett <abartlet at samba.org>
>>>>>
>>>>> Metze, I think your concerns have been addressed, do you have
>>>>> any
>>>>> further comments?
>>>>
>>>> Yes, looks good now.
>>>>
>>>>> Can I get a second team reviewer please?
>>>>
>>>> I've everything reviewed in my master3-python branch:
>>>> https://git.samba.org/?p=metze/samba/wip.git;a=shortlog;h=refs/he
>>>> ads/
>>>> master3-python
>>>
>>> Can we get this pushed to master (or may I collect them from the
>>> branch
>>> and push them?)
>>
>> I've updated my branch.
>>
>> The only question is if we want to wait for the
>> "More ldb/tdb tests" patchset and Matthieu's sign-off.
> 
> I've been asking for it for a month, so I think waiting is pointless at
> this stage.
> 
>> If not I can push the changes tomorrow, after fixing the
>> commit message of the top commit.
> 
> Sounds good.
> 
> Andrew Bartlett
> 

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: OpenPGP digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151104/d6b36f51/signature.sig>


More information about the samba-technical mailing list