winbindd crash

[Noel Power]

On 04/11/15 07:40, Stefan Metzmacher wrote:
> Am 04.11.2015 um 00:59 schrieb Jeremy Allison:
[...]
>  
>  	result = rpccli_netlogon_password_logon(rpcclient_netlogon_creds,
> diff --git a/source3/winbindd/winbindd_pam.c b/source3/winbindd/winbindd_pam.c
> index 0b8ad01..a09143f 100644
> --- a/source3/winbindd/winbindd_pam.c
> +++ b/source3/winbindd/winbindd_pam.c
> @@ -1368,7 +1368,8 @@ static NTSTATUS winbind_samlogon_retry_loop(struct winbindd_domain *domain,
>  		}
>  		netr_attempts = 0;
>  		if (domain->conn.netlogon_creds == NULL) {
> -			DEBUG(3, ("No security credentials available.\n"));
> +			DEBUG(3, ("No security credentials available for "
> +				  "domain [%s]\n", domainname));
>  			result = NT_STATUS_CANT_ACCESS_DOMAIN_INFO;
>  		} else if (interactive && username != NULL && password != NULL) {
>  			result = rpccli_netlogon_password_logon(domain->conn.netlogon_creds,
> This change should be squashed to the first patch, otherwise I'm
> reviewed-by me.
somehow I managed to post the wrong version to the list and attach the
correct version to the bug (multiple machines & disorganized brain)

[...]

On 04/11/15 07:13, Andreas Schneider wrote:
>>> > > 'attached' have also been added at
>>> > > https://bugzilla.samba.org/show_bug.cgi?id=11566 also
>> > 
>> > Also Reviewed-by: Jeremy Allison <jra at samba.org>
>> > 
>> > Metze, are you OK with this part 1 ?
> RB+ but please use DBG_NOTICE
Ah this patch is for the 4.2.x branch so no DBG_NOTICE

Noel

(p.s.) I attach here the actual patches attached to the bug

-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0002-Prevent-null-ptr-access-by-returning-error-if-no-cre.patch
Type: application/mbox
Size: 1043 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151104/7c1f8b68/0002-Prevent-null-ptr-access-by-returning-error-if-no-cre.mbox>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Prevent-null-ptr-access-by-returning-error-if-no-cre.patch
Type: application/mbox
Size: 1336 bytes
Desc: not available
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20151104/7c1f8b68/0001-Prevent-null-ptr-access-by-returning-error-if-no-cre.mbox>