[PATCH] some valgrind related patches

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Nov 3 19:30:24 UTC 2015

On Tue, Nov 03, 2015 at 04:52:29PM +0000, Noel Power wrote:
> Hi,
> was running some tests against our sle (samba-4.2.x) sources, came
> across some valgrind errors, these patches are at least relevant for
> master too

First of all: Thanks for looking into this!

For all patches: Can we get rid of the DEVELOPER ifdefs?

[PATCH 1/6]: R-b: me without the DEVELOPER
[PATCH 2/6]: R-b: me

[PATCH 3/6]: Hmm. Where does this come from? Do we send
more? I'd have thought that we only send what we actually
fill in.

[PATCH 4/6]: Why not ZERO_STRUCT?
[PATCH 5/6]: I'd go with struct lock_struct lock = {0};
[PATCH 6/6]: ENOPATCH? :-)


SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

More information about the samba-technical mailing list