[PATCH] some valgrind related patches

[Jeremy Allison]

On Tue, Nov 03, 2015 at 04:52:29PM +0000, Noel Power wrote:
> Hi,
> was running some tests against our sle (samba-4.2.x) sources, came
> across some valgrind errors, these patches are at least relevant for
> master too

LGTM with the addition that in [PATCH 4/6] fix uninitialised read in process_host_announce
you should remove the

+#if DEVELOPER
+       memset(source_name, 0, sizeof(source_name));
+       memset(announce_name, 0, sizeof(announce_name));
+#endif

and just make it:

+       memset(source_name, 0, sizeof(source_name));
+       memset(announce_name, 0, sizeof(announce_name));

as this should be done in the general (non-developer)
case also IMHO.

Thanks Noel - great work !

Can I get a second Team reviewer ?

Jeremy