[PATCH] Remove duplicate protocol definitions

Volker Lendecke Volker.Lendecke at SerNet.DE
Tue Nov 3 09:25:48 UTC 2015

On Tue, Nov 03, 2015 at 12:52:12PM +1100, Amitay Isaacs wrote:
> The problem is that source3/smbd/server.c and
> source3/smbd/notifyd/notifyd.c include CTDB headers without checking for
> CLUSTER_SUPPORT.  There are two ways to fix this:
> 1. Always check for CLUSTER_SUPPORT before including CTDB headers.
> Additional patches to fix the above two files attached.  These patches add
> #ifdef CLUSTER_SUPPORT checks to the above mentioned files.
> 2. If we need to build smbd with clustering, but restrict the functionality
> at runtime using lp_clustering(), then always build with CTDB and drop the
> --with-cluster-support configure option.
> Volker, if we prefer option 1 then can you please review the patches?



SerNet GmbH, Bahnhofsallee 1b, 37081 Göttingen
phone: +49-551-370000-0, fax: +49-551-370000-9
AG Göttingen, HRB 2816, GF: Dr. Johannes Loxen
http://www.sernet.de, mailto:kontakt at sernet.de

Besuchen Sie uns vom 10.-11.11.15 auf der ISSE!
Information Security Solutions Europe Conference
Hotel Palace Berlin, 20%-Rabattcode: "ISSE15SP"

Meet us at Information Security Conference ISSE!
November 10th - 11th 2015 in Hotel Palace Berlin
For 20% discount take voucher code:  "ISSE15SP"

More information about the samba-technical mailing list