Additional patch for bug 11581

Jeremy Allison jra at samba.org
Mon Nov 2 23:11:31 UTC 2015


On Mon, Nov 02, 2015 at 02:22:06PM +0100, Stefan Metzmacher wrote:
> Hi,
> 
> here's an additional fix for
> https://bugzilla.samba.org/show_bug.cgi?id=11581
> 
> I guess there's no real problem because the cancel
> request is added with DLIST_ADD_END() at the end
> and we would find the real request first in the list.
> And if we really find the cancel request itself
> cur->subreq is still NULL and there's no real problem.
> 
> However we should avoid potential confusion and
> remove the cancel request before looping over
> all requests.
> 
> Please review and push:-)

LGTM - pushed !



More information about the samba-technical mailing list