Comments on GitHub PRs
abartlet at samba.org
Sun Nov 1 18:19:19 UTC 2015
On Sun, 2015-10-25 at 12:18 +0200, Uri Simchoni wrote:
> On 10/25/2015 07:23 AM, Uri Simchoni wrote:
> > Hi Andrew,
> > I tried commenting on a PR in github, figuring that it's easier to
> > do
> > than posting on the list and may serve the contributor better, but
> > it
> > didn't generate an email to the list which breaks the "discussions
> > continue on the list" rule.
> > The gh-mailinglist.py server seems to handle comments, don't know
> > whether GitHub is configured to send them and what's the intent.
> > Can you clarify?
> > The PR in question is https://github.com/samba-team/samba/pull/27
> > Thanks,
> > Uri.
> Well general comments obviously work, I was referring to commenting
> the diff - that's very convenient, instead of downloading the patch
> copy-pasting the relevant line to a reply message. It was this kind
> comment that I generated which didn't generate an email.
That is an interesting observation. The path forward is, I suspect to
investigate (perhaps on a dummy repo) what the web hook it sent in that
case. You can configure web hooks on any repo, and you don't need a
working server to obtain the JSON, github helpfully shows it to you in
their GUI along with the failure.
Of course, formatting such a comment for mailing list consumption may
be quite tricky.
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical