[PATCH] build: fix libarchive detection

Björn Jacke bj at sernet.de
Fri May 29 02:26:55 MDT 2015

On 2015-05-29 at 09:15 +1200 Andrew Bartlett sent off:
> On Thu, 2015-05-28 at 16:52 +0200, Björn Jacke wrote:
> > our libarchive detection was solidly broken, we also don't rely on pkgconfig now.
> What was wrong with relying on pkg-config?  We really should be using
> that as much as possible.

basically I agree that pkg-config should be preferred if available. The
non-pkg-config check should also worth though in any case. And as I've written
in the bug report later on also, the check function that was used was wrong -
conf.CHECK_BUNDLED_SYSTEM works only for our bundeled libraries.

> I would much rather we fix whatever was wrong with using pkg-config, or
> at least use that and recover if we really know there is a broken
> libarchive that:
>  - we still want to use
>  - but has a broken pkg-config

see comment 4 in the bug report. I would apreciate if you can enhance the waf
build system to make proper pkg-config checks for generic libraries including
falback for non-pkg-config checks and the function check feature of
CHECK_FUNCS_IN we can then change the checks of this and actually all the other
external library checks that to such a function. Currently this is wrong and a
limitation of waf obviously. I'll change the comment as sugested by David.

-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 181 bytes
Desc: Digital signature
URL: <http://lists.samba.org/pipermail/samba-technical/attachments/20150529/9e1de9df/attachment.pgp>

More information about the samba-technical mailing list