[PATCH v3] s3: libsmbclient: Add server-side copy support

Jeremy Allison jra at samba.org
Thu May 28 16:57:09 MDT 2015


On Wed, May 27, 2015 at 11:13:15PM +0100, Ross Lagerwall wrote:
> Introduce a new operation, splice, which copies data from one SMBCFILE
> to another. Implement this operation using FSCTL_SRV_COPYCHUNK_WRITE for
> SMB2+ protocols and using read+write for older protocols. Since the
> operation may be long running, it takes a callback which gets called
> periodically to indicate progress to the application and given an
> opportunity to stop it.
> 
> Signed-off-by: Ross Lagerwall <rosslagerwall at gmail.com>
> ---
> 
> Thanks for the reviews. David, I'm not sure if you intended for me to
> fold in the ABI change patch, so I kept it separate for now.
> 
> Changes in v3:
> * Rebased against master.
> * Added some overflow and underflow checks.

LGTM Ross - thanks a *LOT* for this work. Pushed to autobuild.


More information about the samba-technical mailing list