[PATCH] s4-openldap:Fixed a crash when provisioning with openldap backend
Andrew Bartlett
abartlet at samba.org
Thu May 21 06:36:03 MDT 2015
On Thu, 2015-05-21 at 11:45 +0200, Nadezhda Ivanova wrote:
> backendType = ldb_get_opaque(ldb, "openLDAPbackend");
Sorry to nit-pick, but make that string "samba_dsdb_backend".
One other point:
+ if (!data->openLDAPbackend) {
Can we make that
+ if (data->openLDAPbackend == false)
it isn't in the coding style, but I think it's much clearer. Do those
then it's OK. Reviewed-by: Andrew Bartlett <abartlet at samba.org>
--
Andrew Bartlett http://samba.org/~abartlet/
Authentication Developer, Samba Team http://samba.org
Samba Developer, Catalyst IT http://catalyst.net.nz/services/samba
More information about the samba-technical
mailing list